search

CouncilDataProject / cdp-backend

Data storage utilities and processing pipelines used by CDP instances.
https://councildataproject.org/cdp-backend
Mozilla Public License 2.0
22 stars 26 forks source link

#239: bug/firestore_native_mode - in deploy, ensuring firestore database is configured in native mode #240

Closed gregoryfoster closed 9 months ago

gregoryfoster commented 9 months ago

Link to Relevant Issue

This pull request resolves #239

Description of Changes

Adds call to:

gcloud alpha firestore databases update --type=firestore-native

in the deploy workflow in the Justfile. Has not been tested! And might be better situated more immediately after the creation of the firestore database in the setup workflow. But I just placed it in the location identified in the related issue as when the issue arises, so it should be fine as is.

evamaxfield commented 9 months ago

I will run a quick deploy test in ~30 minutes!

evamaxfield commented 9 months ago

I think the issue causing failures here is a simple missing dependency that spacy added in the last few months. When I try my deploy I will try and fix

evamaxfield commented 9 months ago

@gregoryfoster can you pull and merge main? I just pushed a commit that should fixed the pipeline

evamaxfield commented 9 months ago

Actually I am going to close this as I tested out your change and it was almost correct but had to move some stuff around and add a sleep statement. All of the changes were pushed here:

https://github.com/CouncilDataProject/cdp-backend/commit/8f72ae75492d231cd13353bd44cb02ed2fbbe732

Thanks for finding the correct command to use because finding the right spot was a breeze