search

CouncilDataProject / cdptools_v2

Tools you can use to interact with and run Council Data Project instances.
Other
7 stars 9 forks source link

Fix WebVTT SR Model check for speaker annotation #118

Closed evamaxfield closed 4 years ago

evamaxfield commented 4 years ago

Description

A clear description of the bug The first events to use the new model look great but they have a bug when new speaker symbols follow non-dialog symbols. [Applause]>> for example. I assume it's because are looking for a white space character before the start of the speaker turn character.

Expected Behavior

What did you expect to happen instead? It should be:

{dialog}
[Applause]
{dialog}

Or just filter out any non-dialog text

Reproduction

A minimal example that exhibits the behavior. https://councildataproject.github.io/seattle/#/events/37f0be31-c075-4701-be70-a41323ea8a1a

Environment

Any additional information about your environment

evamaxfield commented 4 years ago

Resolved in #119