ops/test-seattle-parse-single-event-scraper

isaacna commented 4 years ago

Pull request recommendations:

[x] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
[x] Provide context of changes.
- Added a test for the Seattle event scraper method for processing a single event because I forgot to do that earlier
- Added in a real sample test file. Let me know if you don't actually want the whole HTML file as test data.
- Removed line length check for event scraper tests as this could be over-sensitive on event scraper tests in the feature
- Make some backfill lint fixes that were randomly started appearing
[x] Provide relevant tests for your feature or bug fix.

Thanks for contributing!

isaacna commented 4 years ago

It seems the lint validation is failing due to the long lines from mock data in the test file even though line I added in tox.ini should ignore that. I'm guessing GitHub is running flake8 command off the current tox.ini?

isaacna commented 4 years ago

That's pretty cool I didn't know that you could add inline ignores!

Also I cleaned up my master branch that was out of sync so this PR should only have the related commit in it.

CouncilDataProject / cdptools_v2

ops/test-seattle-parse-single-event-scraper #126