feature/minimal-event-data-scraper

[isaacna]

Pull request recommendations:

• [x] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
• [ ] Link to any relevant issue in the PR description. Ex: Resolves [gh-12], adds tiff file format support
• [x] Provide context of changes.
  • PR for the minimal event data scraping methods. Doing this before making a prefect pipeline minimal event gather PR just to keep them from being too large
• Created a MinimalEventData object
• Added session support with a MinimalSessionData object, with a MinimalEventAndSessionData class that helps us handle the data for intermediate operations before matching sessions to events
• My session matching implementation only works under the assumption that there can be at most 2 sessions. I wrote it kinda fast and didn't realize there could potentially be more than 2, but I can just adjust that if we do find some edge cases
• [x] Provide relevant tests for your feature or bug fix.
  • Have done manual testing, parsing logic is essentially the same as other parsing methods
  • Paste showing the results of a MinimalEventGather (with sessions): https://pastebin.com/uBqpDPpn
• [ ] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

[evamaxfield]

@isaacna

Also for point 2, you mean staging-seattle would primarily just hold city specific stuff (scrapers, etc.) and pull in all the generalized tools as needed?

Yes that would be exactly correct

[evamaxfield]

@tohuynh if you are also happy with this I think you can merge @isaacna

I do think we will need to add an Optional[List[MinutesItem]] at some point down the line but that can be added after we get the basic pipeline and repo constructed that I described above.

[isaacna]

Some notes on these updates:

• The 2 session assumption could be limiting in the future, but since it's on the scraper side and I haven't seen edge cases (which I think would be held separately from our cdp-backend repo), I decided to roll with it. I can change it in the future if needed
• I decided to add "Minimal" for the new classes to not make the current cdptools code confusing, but will change it to just "event" and "session" when moving to cdp-backend
• The legistar attaching functioning only attaches body for now, but if we want to add minutes_items I can update that in a later pr (possibly after porting to cdp-backend)

[isaacna]

Sounds good, I'll note that on this issue. And minutes items are shared across sessions for the same event right?

[evamaxfield]

Sounds good, I'll note that on this issue. And minutes items are shared across sessions for the same event right?

For now, yes they are EventMinutesItems. I can imagine a future where we get fine grained enough for SessionMinutesItems though. But no need to worry about that just yet.

Feel free to merge whenever.