search

CouncilDataProject / cdptools_v2

Tools you can use to interact with and run Council Data Project instances.
Other
7 stars 9 forks source link

bugfix/cdp-instance-init-import-error #61

Closed evamaxfield closed 5 years ago

evamaxfield commented 5 years ago

This fixes a bug that occurs when not all dependencies are installed. Specifically, not all dependencies required for database and file store modules.

What was happening was due to how instances of CDPInstance were initialized, (by passing an object type) it would attempt to fully import that object prior to initializing the object. In the case where dependencies were missing, it would throw an error.

codecov[bot] commented 5 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   92.74%   92.78%   +0.03%     
==========================================
  Files          43       45       +2     
  Lines        2330     2341      +11     
==========================================
+ Hits         2161     2172      +11     
  Misses        169      169
Impacted Files Coverage Δ
...dptools/tests/dev_utils/test_load_custom_object.py 100% <100%> (ø)
...ools/tests/pipelines/test_event_gather_pipeline.py 100% <100%> (ø) :arrow_up:
cdptools/pipelines/event_index_pipeline.py 100% <100%> (ø) :arrow_up:
cdptools/pipelines/pipeline.py 90.9% <100%> (-4.33%) :arrow_down:
cdptools/dev_utils/load_custom_object.py 100% <100%> (ø)
cdptools/configs.py 100% <100%> (ø)
...ests/pipelines/test_minutes_item_index_pipeline.py 100% <100%> (ø) :arrow_up:
cdptools/pipelines/event_gather_pipeline.py 96.61% <100%> (ø) :arrow_up:
cdptools/cdp_instance.py 89.47% <100%> (ø)
cdptools/pipelines/minutes_item_index_pipeline.py 95.6% <100%> (ø) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57a21cc...a1a3903. Read the comment docs.