Closed evamaxfield closed 4 years ago
Merging #72 into dev will decrease coverage by
2.45%
. The diff coverage is50%
.
@@ Coverage Diff @@
## dev #72 +/- ##
==========================================
- Coverage 92.48% 90.02% -2.46%
==========================================
Files 45 46 +1
Lines 2394 2396 +2
==========================================
- Hits 2214 2157 -57
- Misses 180 239 +59
Impacted Files | Coverage Δ | |
---|---|---|
cdptools/databases/database.py | 82.42% <ø> (ø) |
:arrow_up: |
cdptools/databases/cloud_firestore_database.py | 85.56% <ø> (-2.82%) |
:arrow_down: |
cdptools/pipelines/event_gather_pipeline.py | 55.93% <ø> (-40.68%) |
:arrow_down: |
...tests/event_scrapers/test_seattle_event_scraper.py | 100% <ø> (ø) |
:arrow_up: |
cdptools/dev_utils/check_system_version.py | 0% <0%> (ø) |
|
cdptools/legistar_utils/events.py | 74.07% <75%> (-0.93%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 97406d3...748713b. Read the comment docs.
This changes the database schema for minutes items from
name
totitle
. As a part of that theSeattleEventScraper
(legistar_utils.events.parse_legistar_event_details
) now chooses theEventItemTitle
over theEventItemMatterName
.A new pipeline is available to update events in the database as new Legistar data becomes available.
A backfill / migration script is also available to change the column names on the
minutes_item
table.