sort votes and add links for each person in votes tab

CouncilDataProject / seattle_v2

Website for interacting with Seattle's instance of CDP

https://councildataproject.github.io/seattle

BSD 3-Clause "New" or "Revised" License

5 stars 6 forks source link

sort votes and add links for each person in votes tab #30

Closed tohuynh closed 4 years ago

tohuynh commented 5 years ago

Issues 14 and 15. Sort the decision items base on index so that they appear in the same order as minutes in details. Add links to each person. Sort persons alphabetically. Remove table headers on smaller screens

tohuynh commented 5 years ago

Issue 19 Replace event link icon with body name and event datetime. Sort votes according to datetime, and then index, both in descending order so that the person's most recent decision appears first.

evamaxfield commented 4 years ago

Thanks for your PR!

Relevant issues:

Resolves #14
- Staging Example
- Notes: Go to votes tab
Resolves #15
- Staging Example
- Notes: Go to votes tab
Resolves #19
- Staging Example
- Notes: n/a

Notes to other reviewers: n/a

evamaxfield commented 4 years ago

Also as general feedback, this is not an issue for now, but in the future, it may be useful to revisit how sorting is currently being done client side. GH #24 and the related branch has new database interaction functions that allow for sorting on server side which should reduce render times.