search

CouncilDataProject / seattle_v2

Website for interacting with Seattle's instance of CDP
https://councildataproject.github.io/seattle
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

Add timestamped speaker turns to event page #51

Closed tohuynh closed 4 years ago

tohuynh commented 4 years ago

In light of #101, the front-end of transcripts should be updated to show new timestamped-speaker-turns format.

I'm thinking maybe group the sentences together for a speaker turn block. That is, just add a horizontal line between each speaker turn block. If there's a speaker, show that above each speaker turn block.

I think the transcript under Search Transcript can remain the same, regardless of formats.

evamaxfield commented 4 years ago

Agree on all fronts.

evamaxfield commented 4 years ago

Similar to the backend PR linked, I would make it a try catch. Or if you wanted to be really fancy, have a transcript renderer map. Where given the transcript format string it returns the content ready to display.

tohuynh commented 4 years ago

Similar to the backend PR linked, I would make it a try catch. Or if you wanted to be really fancy, have a transcript renderer map. Where given the transcript format string it returns the content ready to display.

Thanks for this recommendation. I'm using the transcript renderer map. Here's a preview of what speaker-turn blocks looks like.

image

Any thoughts?

evamaxfield commented 4 years ago

This already looks awesome. I only have nitpicky things.

Nitpicky things:

  1. I think if the speaker is an empty string instead of enumerating the speaker, just make it say "New Speaker"?
  2. Not a part of this issue or upcoming PR, but I am starting to notice that maybe the event details, both the transcript, the voting records, and the minutes content width should be smaller. The content looks odd when the video is cutting off the upper corner. In my opinion anyway. If you agree I will make another issue for it that I think even I can solve because it should just be css changes.
evamaxfield commented 4 years ago

Mind if I send this for feedback by UX peeps too?

tohuynh commented 4 years ago

No, not at all.

  1. The speaker is just fake data. I won't show speaker at all if it is unknown.
  2. Sure, add screenshots too please.
evamaxfield commented 4 years ago
  1. Meh I would still say "New Speaker" when it is an empty string but will hear back from others.
  2. Sounds good.
tohuynh commented 4 years ago

image

This one is for timestamped-sentences. I could use any input on that too.

evamaxfield commented 4 years ago

I think for timestamped-sentences can we keep the current render? Having a card per sentence makes it feel like a lot is going on.

tohuynh commented 4 years ago

Ok, will switch back.

evamaxfield commented 4 years ago

Resolved in #57