CouncilDataProject / seattle_v2

Website for interacting with Seattle's instance of CDP
https://councildataproject.github.io/seattle
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

bugfix/adjust-media-breakpoints #56

Closed evamaxfield closed 4 years ago

evamaxfield commented 4 years ago

Pull request recommendations:

While playing around with picture in picture adjustments and experimenting with breakpoints the nitpickiness in me found two small changes that I think result in a better UI given any size window.

The first is an adjustment to when the event search component drops to below the video. I just set it at 1200px nothing else special and it seems to looks pretty good.

The second is adjustment to when the timestamps drop to below each sentence text. Which is now set to 1000px. This one was because there was a weird spot in between 720px and 1000px that resulted in the play icon and the timestamp text being on a split line. This makes it so that the icon and the timestamp text will always be on the same line.

Thanks for contributing!