[GH-51]feature/add-timestamped-speaker-turns

[tohuynh]

Pull request recommendations:

• [x] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
• [x] Link to any relevant issue in the PR description. Ex: Resolves [gh-12], adds tiff file format support

  51. And also #49, where the feature to jump to transcript portion from videoTimePoint was requested.

• [x] Provide context of changes. Add UI changes to show timestamped-speaker-turns. I ran into a little block trying to add the jump to transcript portion feature. Unfortunately I couldn't use that "card" UI for each speaker-turn. Instead I have a horizontal divider with speaker at the top of each speaker-turn. Also I used New Speaker for empty string speaker as requested. Here's what it looks like:
• [x] Provide relevant tests for your feature or bug fix.
• [x] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

[evamaxfield]

Before I review, how did you test this without any speaker turns transcripts existing in the database? / How can I test this haha

[evamaxfield]

Also from the changes, am I assuming correctly that the same code is used for scrolling to position as is the EventTranscriptSearch? So when you click on a result in the Event Transcript Search it will also scroll to that position in the full transcript as well?

[tohuynh]

Also from the changes, am I assuming correctly that the same code is used for scrolling to position as is the EventTranscriptSearch? So when you click on a result in the Event Transcript Search it will also scroll to that position in the full transcript as well?

I'm not following the question. There is no automatic scrolling in EventTranscriptSearch. It just renders the sentences that contains the searchText.

[evamaxfield]

Also from the changes, am I assuming correctly that the same code is used for scrolling to position as is the EventTranscriptSearch? So when you click on a result in the Event Transcript Search it will also scroll to that position in the full transcript as well?

I'm not following the question. There is no automatic scrolling in EventTranscriptSearch. It just renders the sentences that contains the searchText.

Right but the onclick of any of the results, does that onclick now also scroll to the full transcript position of that clicked result?

[tohuynh]

Right but the onclick of any of the results, does that onclick now also scroll to the full transcript position of that clicked result?

Oh do you mean the onclick of the play button?

[evamaxfield]

Right but the onclick of any of the results, does that onclick now also scroll to the full transcript position of that clicked result?

Oh do you mean the onclick of the play button?

Yep!

Sidenote: GitHub should really look into a thread system for conversations.

[tohuynh]

Right but the onclick of any of the results, does that onclick now also scroll to the full transcript position of that clicked result?

Oh do you mean the onclick of the play button?

Yep!

Sidenote: GitHub should really look into a thread system for conversations.

No, it doesn't do that right now. That's a good idea. This can be done I think through sending a custom-event and have EventTranscript listen for that event and then scroll to right portion.

[tohuynh]

New changes removed react-virtualized components from EventTranscript and uses element.scrollIntoView to do the scrolling.

It scrolls to the transcript portion if there's a videoTimePoint in the URL, or the user clicks a transcript portion's play button in Search Transcript.