feature/add-error-handling

[tohuynh]

Pull request recommendations:

• [x] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
• [x] Link to any relevant issue in the PR description. Ex: Resolves [gh-12], adds tiff file format support Resolves #69
• [x] Provide context of changes. Add a general component to catch almost all errors. Also did some code refactoring.

The key files are: useDataApi.js is a custom hook to fetch data from the database. I lifted the data fetching logic in all /containers components into this custom hook.

DataApiContainer.jsx is a general wrapper component to render the returned data of an API call. If there was an error from the API call, it will throw an error. Or if data fetching is in progress, it will show the loader. If data fetching succeeded it will show the data. I lifted all conditional rendering logic in /containers components into DataApiContainer.jsx.

GeneralErrorBoundary.jsx is the component to catch errors and display the error message. I use it by wrapping it around a component like so:

<GeneralErrorBoundary>
  <Component/>
</GeneralErrorBoundary>

GeneralErrorBoundary will catch JavaScript errors anywhere in the child component tree and display the fallback UI.

I use GeneralErrorComponent at two 'levels'. One top-level in App.js. And one for each component in /pages.

• [ ] Provide relevant tests for your feature or bug fix.
• [x] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

[evamaxfield]

Actually I do have a minor request:

Can you make the text:

Please fill out a Github issue so we can address it soon :)

To be:

Sorry about that. To alert us of the issue, please fill out an issue ticket and we will try to fix it as soon as we can.

and make issue ticket link to this repo's github issues?

[tohuynh]

Actually I do have a minor request:

Can you make the text:

Please fill out a Github issue so we can address it soon :)

To be:

Sorry about that. To alert us of the issue, please fill out an issue ticket and we will try to fix it as soon as we can.

and make issue ticket link to this repo's github issues?

Yes issue ticket will link to https://github.com/CouncilDataProject/seattle/issues/new/choose