admin/replace-heavy-nlp-deps-with-stemmer

CouncilDataProject / seattle_v2

Website for interacting with Seattle's instance of CDP

https://councildataproject.github.io/seattle

BSD 3-Clause "New" or "Revised" License

5 stars 6 forks source link

admin/replace-heavy-nlp-deps-with-stemmer #82

Closed evamaxfield closed 4 years ago

evamaxfield commented 4 years ago

Pull request recommendations:

[x] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
[x] Link to any relevant issue in the PR description. Ex: Resolves [gh-12], adds tiff file format support
[x] Provide context of changes.

The build "succeeded" but fails on the actual live website due to weird stupid large dependencies that we really don't need (I think)

[ ] Provide relevant tests for your feature or bug fix.
[ ] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

evamaxfield commented 4 years ago

Tested deployment here: https://jacksonmaxfield.github.io/seattle/#/

IT WORKS THIS TIME :tada:

evamaxfield commented 4 years ago

about previous pr:

const Banner = () => (
  <Container style={{ backgroundColor: "#ededf0", padding: "1em 1em", width: "100vw"}}>
      <p>
          Support this project by&nbsp;
          <a
            href="https://forms.gle/eGyjhPx4hU3UBidKA"
            style={{ textDecoration: "underline" }}
          >
            giving your feedback &gt;
          </a>
      </p>
  </Container>
);

This is a little bit better to read?

I put the &nbsp to make sure that the link is always on a single line even on small screens. Which makes it imo look a lot better. Try it in responsive mode on various devices. Looks better with it all on one line than split imo.

evamaxfield commented 4 years ago

But I will change the > to >

tohuynh commented 4 years ago

about previous pr:
const Banner = () => (
  <Container style={{ backgroundColor: "#ededf0", padding: "1em 1em", width: "100vw"}}>
      <p>
          Support this project by&nbsp;
          <a
            href="https://forms.gle/eGyjhPx4hU3UBidKA"
            style={{ textDecoration: "underline" }}
          >
            giving your feedback &gt;
          </a>
      </p>
  </Container>
);
This is a little bit better to read?
I put the &nbsp to make sure that the link is always on a single line even on small screens. Which makes it imo look a lot better. Try it in responsive mode on various devices. Looks better with it all on one line than split imo.

I see. Yea it does look better. but can we change > to >. the > is giving an error message in my editor (no big deal)