CouncilDataProject / seattle_v2

Website for interacting with Seattle's instance of CDP
https://councildataproject.github.io/seattle
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

feature/use-cdp-instance-filters #85

Closed tohuynh closed 4 years ago

tohuynh commented 4 years ago

Pull request recommendations:

Thanks for contributing!

tohuynh commented 4 years ago

This all looks great and I am excited about the changes. I think it makes sense that when something a sort or filter option is selected it changes the background color to dark gray but it may be nice to get other opinions on this. The idea being, instead of changing to dark gray it is just always off white, when selected or not.

Want to hold this for discussion on Wednesday?

Sure. I think there should be at least a visual indication(beyond just changing the text) that the filter is selected. Dark gray background is too much? We can think of other ways. I'm OK with sort button remaining white, regardless.