search

CouncilDataProject / speakerbox

Speakerbox: Fine-tune Audio Transformers for speaker identification.
https://councildataproject.org/speakerbox
MIT License
52 stars 6 forks source link

datasets ~=1.18 requirement introduces conflict w/ numpy > 1.23 #24

Open gregoryfoster opened 11 months ago

gregoryfoster commented 11 months ago

Describe the Bug

speakerbox requires datasets~=1.18 which in turn requires numpy>=1.17. The datasets 1.x line hasn't been updated since mid-2022. numpy v1.20 deprecated use of aliases of built-in types and expired those deprecations in v1.24. The datasets 1.x line uses those aliases, so a default install of speakerbox fails during training.

Expected Behavior

Training should work.

Reproduction

pipenv install speakerbox==1.2.0 Use speakerbox.train()

Environment

gregoryfoster commented 11 months ago

To workaround, install numpy <= v1.23.

evamaxfield commented 11 months ago

Is the fix for this just updating the numpy pin / the datasets pin in the library?

kristopher-smith commented 2 months ago

This could probably benefit from a requirements.txt file.