search

CounterpartyXCP / counterblock

Provides extended API services to Counterwallet, as well as Counterparty 3rd-party applications
http://counterparty.io
MIT License
16 stars 68 forks source link

Is get_insight_block_info() broken? #184

Open cryptcoin-junkey opened 3 years ago

cryptcoin-junkey commented 3 years ago

https://github.com/CounterpartyXCP/counterblock/blob/a564eeb1f50bef7ce8ee0dd702415bdc1a1d3bd3/counterblock/lib/processor/api.py#L58-L61

I couldn't blockchain.getBlockInfo() in the develop branch. Should we remove this API or fix to work again?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/95769362-is-get_insight_block_info-broken?utm_campaign=plugin&utm_content=tracker%2F686853&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F686853&utm_medium=issues&utm_source=github).
chiguireitor commented 3 years ago

Counterblock is slowly slipping into obsolescence tbqh. I don't know if this call is used by counterwallet, but it would probably be better if any new wallets developed for the project try to rely as little as possible on counterblock in the future.

cryptcoin-junkey commented 3 years ago

As far as the result of my roughly grepped in Counterwallet, there is no code calling get_insight_block_info(). So we can drop it, IMO.

Is there no issue on your services even if I remove the API ? @jdogresorg

jdogresorg commented 3 years ago

I do not use get_insight_block_info() anywhere on xchain.io or in freewallet.io

cryptcoin-junkey commented 3 years ago

@jdogresorg I see. I'll create PR to remove get_insight_block_info() soon.

@chiguireitor I agree that Clounterblock (and Counterwallet) should be going to be obsolete. And at least just now, it's required to follow up with current code by current users, IMO.