search

CounterpartyXCP / counterparty-core

Counterparty Protocol Reference Implementation
http://counterparty.io
MIT License
284 stars 206 forks source link

Eliminate All Generic Exception Handling #1381

Open adamkrellenstein opened 7 months ago

adamkrellenstein commented 7 months ago
Screenshot 2024-02-01 at 12 06 36 PM
ouziel-slama commented 5 months ago

In this generic except we just cast any error in ParseTransactionError().. it's only cosmetic we could just delete these two lines.. the main thing is, here, if there is an error while parsing a transaction the server crashes..and that's what we want because that should never happen.. I think we should just leave it like that.. on the other hand we have to make sure that there is no generic Except during the parsing of transactions which would make this Except useless.. normally we have already removed those that were there..

adamkrellenstein commented 5 months ago

Sorry yes that's what I meant for this issue... remove all generic exception handling!

Maybe we should do that as part of a protocol change though?

ouziel-slama commented 5 months ago

yeah I think so! There are a few left in unpack functions but I looked around and a priori nothing dangerous.