CounterpartyXCP / counterparty-core

Counterparty Protocol Reference Implementation
http://counterparty.io
MIT License
284 stars 206 forks source link

multi send error #1383

Open KaneMayfield opened 7 months ago

KaneMayfield commented 7 months ago

having a problem doing a multi send... getting this error It looks like my "second send" gets hung up or something... im barely technical enough to find the github... i was directed to put it here

Error validating transaction: Error running script for input 0 referencing 117e8bffa27feeccc331f53ff03df9fa0e930404cc96436c9b0565b9fe1c1303 at 0: scriptsig not push only for P2SH. Screenshot 2024-02-01 191246

adamkrellenstein commented 7 months ago

Thanks for submitting this! Unfortunately that's a hard thing to debug... because the transaction is being produced by Freewallet. We going to need some more details of the contents of the transaction, log files, something. :/

Can you reproduce the error reliably? What are the exact steps you take to do so?

davestaxcp commented 7 months ago

So a few members of the community that use Multi-Send very frequently have reported this issue

11/29/23

image

1/25/24

image

1/29/24

image

and there is a few places this issue (or something similar) have been referenced on the Freewallet Github at even earlier dates:

https://github.com/jdogresorg/freewallet-desktop/issues/124

https://github.com/jdogresorg/freewallet-desktop/issues/152

B0BSmiths noted on his experience with using this feature and a Trezor wallet:

"I have found the signing of the second TX in a multisend is problematic on Trezor. The Trezor sees the OP return but it ignores the PS2H encoded inputs. It then consumes and an entire UTXO on mining fees as there is no change in the TX and broadcasts the op return without signing the P2SH encoded inputs, so an unrelated entire utxo is consumed and your multisend fails"

Though to note, in Issue 152, Subterranean mentions he was not using the Hardware wallet functionality at all.

In an early discussion with B0B we assumed it may be something to do with how fees:

image image At the time there were tx id's with the info on it, but they have since been purged (too low of a few in mempool) image

image



  1. has alot of UTXO's trying to do this function and

  2. usually arent willing to wait and instead: instantaneously try again using a different fee or just pushing through multiple unconfirmed tx's

adamkrellenstein commented 7 months ago

Ach yeah, all of that information is great, but what we need is a way to reproduce the issue reliably. If it only happens rarely, then it won't be productive to just spam MPMA until it happens. We need either:

  1. Steps to reproduce the issue reliably, or
  2. Logs from Freewallet showing the series of API requests against the API that failed, or
  3. Detail from users specifying exactly what parameters they put into Freewallet on what date so we can reproduce (2) ourselves.