search

CounterpartyXCP / counterparty-core

Counterparty Protocol Reference Implementation
http://counterparty.io
MIT License
284 stars 206 forks source link

mainnet test suite #369

Open adamkrellenstein opened 9 years ago

adamkrellenstein commented 9 years ago

Why wasn't this bug caught by the test suite? 1ca58b2cf87b678359408b9662818d25c90080f1

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

adamkrellenstein commented 9 years ago

Are we running everything against testnet only?

robby-d commented 9 years ago

Eh, bad if so...mainnet + testnet

mtbitcoin commented 9 years ago

May I know what effect does this bug have? I am currently stuck on the checking version prompt (windows). I did already pull the latest changes

Status: Connecting to database. Status: Running v9.45.0 of counterpartyd. Status: Checking version.

adamkrellenstein commented 9 years ago

It has nothing to do with the version checks. That's slow because we're still using GitHub for hosting the minimum version information.

The bug is fixed in the latest versions on develop and master, anyway. It just threw an error on the construction of some transactions via the API.

ouziel-slama commented 9 years ago

Only books test is also done on mainnet.

adamkrellenstein commented 9 years ago

@JahPowerBit What do you think? Is there a way we can check, maybe at least the API calls, on mainnet, too?

ouziel-slama commented 9 years ago

Since the test suite can run without bitcoind, a priori we can run all the test suite on mainnet. Just need to create fixtures.. I will work on this asap.

adamkrellenstein commented 9 years ago

bump

ouziel-slama commented 9 years ago

see https://github.com/CounterpartyXCP/counterpartyd/issues/459 I'am working to execute all the tests also in mainnet. My concern is protocol changes. Block number are arbitrary in the test suite, and if we want that the test suite always tests the last protocol version, I need to change the first block on each protocol change.. This can be resolve with this https://github.com/CounterpartyXCP/counterpartyd/issues/458 If in the code we are working with versions instead block number, I have just to set the last version with the first block.

adamkrellenstein commented 9 years ago

@JahPowerBit, #458 is now solved. Is this now relatively straightforward?

ouziel-slama commented 9 years ago

@adamkrellenstein, not really. The "easy" way is to just duplicate all the folder fixtures, but that become a mess to maintain/check new fixtures when there is protocol changes. The second solution is to use a "template" for fixtures, but in this case we lost hashes coverage. I need to find a way to reduce the volume of fixtures and keep the same coverage..