search

CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 163 forks source link

License Agreement says "before May 8th 2014" instead of "after" #640

Open ghost opened 9 years ago

ghost commented 9 years ago

"If you are trying to access a wallet created before May 8, 2014, you have typed the passphrase incorrectly."

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

ghost commented 9 years ago
ghost commented 9 years ago

It is still incorrect.

If they have a wallet created before May 8, it will not be accessible even if the passphrase is correct. (As you said that has to be prefixed by old.) If the wallet is created after May 8, then the only way this screen can pop up is if the passphrase has been typed incorrectly (hence the warning).

I propose: 'If you are trying to access a wallet created after May 8, 2014, you have typed the passphrase incorrectly. Otherwise, please add "old " before the 12 word passphrase and try again.'

ghost commented 9 years ago

If they have a wallet created before May 8, it will not be accessible even if the passphrase is correct.

The wallet won't be, but a wallet will be. What the warning is saying is this: "If your pass phrase is "like just love know never want time out there make look eye" and you first started using Counterwallet before May 8, 2014, you are logging in to a different wallet from what you expect."

Why? Because in that case you should probably add "old " before that pass phrase.

But the warning appears to anyone, not to only some users who used some particular pass phrase. It appears even to people who created a completely new address on the same server just 5 seconds ago.

There is no "incorrect" pass phrase, it's the main message we deliver to users confused about pass phrases. Any 12 word combo from the 1600+ word list will do. You can login like this: "like like like like like like like like like like like like". Counterwallet can't a priori know if your "12x like" is correct or whether you should be using "old " + "12x like". It just warns anyone and everyone precisely because it can't tell. If you prefix that pass phrase with "old like like like ..." then it will know for sure and use the old method to determine a list of your addresses.

You can edit the string and create a pull request in develop branch: https://github.com/CounterpartyXCP/counterwallet/blob/develop/src/locales/en/translation.json

Edit: to add another point - a CW instance (or a cluster) remembers wallet IDs until it's reinstalled. Then it loses memory of what happened. While it may be possible to determine that the user just clicked on the Create New Wallet button, CW can't know what was the pass phrase that the user just entered. I agree that the wording isn't very clear, so if you think it can be better feel free to submit a pull request, but consider that - until it is translated into the 5-6 other languages - it will appear in English and may confuse more users than it would help (because the number of users who haven't logged on in the past 8 months must be very small in comparison.)

ghost commented 9 years ago

True, I guess we shouldn't imply incorrect/corect passphrases. But it's not really clear. And as you said we shouldn't really let people know about adding "old" behind the passphrase since it is a security risk and may confuse them even more.

Maybe just say if the passphrase was created before May 8, you should contact support/go to this page... I figure most people will have switched by now. That way we don't risk confusing anyone, or messing up the translations.