search

CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 163 forks source link

Allow `OP_RETURN`; use`'auto'` encoding #688

Closed adamkrellenstein closed 9 years ago

adamkrellenstein commented 9 years ago

See https://github.com/CounterpartyXCP/counterpartyd/pull/691#issuecomment-72703360.

ouziel-slama commented 9 years ago

done here: https://github.com/CounterpartyXCP/counterwallet/commit/9924487433c0b1d5ae1397bc65d2866704573ae3

btcdrak commented 9 years ago

As far as I am aware this isnt enough.

You also need to make a change in counterwallet to use auto encoding. See what we did for clearwallet.

https://github.com/ClearingHouse/clearwallet/commit/2327c79eed32f10b756408663b26cd56d646a30b

Which also relies on this which we got merged into Bitcore https://github.com/bitpay/bitcore/commit/0977a2c23b7ad4f20467aa70237d097b0b41eb05

And this https://github.com/ClearingHouse/clearwallet/commit/0d0b4b925a48a34fe7265929a6909bd7d1e092e5

btcdrak commented 9 years ago

OK I've ported the remaining parts required to make counterwallet use OP_RETURNs where possible in the two PRs above. After https://github.com/CounterpartyXCP/counterwebdeps/issues/6 is merged grunt will need to be updated for this repo.

ouziel-slama commented 9 years ago

@btcdrak: thanks again, I have updated the counterwebdeps version.