CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 162 forks source link

DEX Order Rounding => No Match #717

Open Jpja opened 9 years ago

Jpja commented 9 years ago

fldc orderbook counterwallet

The sell order was submitted as shown in the "Sell FLDC" form. After submission, the XCP total was rounded up, hence the price was also rounded up.

Result; the sale did not match the highest bid.

Proposed solution; always round the XCP total DOWN (if rounding is needed) when selling, and round XCP total UP when buying.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9655644-dex-order-rounding-no-match?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github).