CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 162 forks source link

Implement Armory multisig support? #733

Open ivanaszuber opened 9 years ago

ivanaszuber commented 9 years ago

A user reported he is not able to get his funds out of a Counterwallet multisig composed out of 3 armory addresses.

Apparently Armory doesn't support signing transaction formats from other applications. Their developer said "Counterwallet can implement Armory's transaction format, so Armory should be able to treat it like signing any other Armory transaction."

Can this be done? If not, can we add a message somewhere that multisig with Armory is currently not supported?

NOTE: I've been trying to test this myself but can't get Armory to work :/. Address balance keeps getting reset to 0 (even after rebuild and rescan). For some reason Armory can't find the transactions associated with the addresses in the wallet :(. If needed I can provide the full report from the user who reported the multisig issue

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12964655-implement-armory-multisig-support?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github).
Daruhshie commented 9 years ago

robby-d commented 8 years ago

hopefully this will be possible with the pending P2SH support. keeping this open as a todo to verify once P2SH is merged...

unsystemizer commented 8 years ago

@robby-dermody which Armory version is officially supported (or will be officially supported once P2SH is available for testing)? Is it 0.93.3 (as per https://github.com/CounterpartyXCP/federatednode_build/blob/master/run.py#L726)?

I want to try this and https://github.com/CounterpartyXCP/counterwallet/issues/677 once P2SH support is available.

robby-d commented 8 years ago

yes, 0.93.3 versions before 0.93.2 (I think?) don't support bitcoind >= 0.12 due to the malleability fix