CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 162 forks source link

Unable to cancel an open order #734

Closed ivanaszuber closed 9 years ago

ivanaszuber commented 9 years ago

Canceling an open order gives the error:

failoverAPI: Call failed (failed over across all servers). Method: broadcast_tx; Last error: JSON-RPC Error:
Type: Server error

Code: -32000

Message: Bad status code returned: '500'. result body: '{"result":null,"error":{"code":-26,"message":"64: scriptpubkey"},"id":0} '.

After that the Cancel button is disabled and the order still open (visible in the Market and in Open orders)

pryds commented 9 years ago

For what it's worth, it seems that information about the disabled button is only stored client-side, suggesting that the order is still genuinely open. If I log in via another browser, I can click the cancel button again (and get the same error message again).

ouziel-slama commented 9 years ago

@ivanaszuber: I can not reproduce. Is it happens every time or only sometimes? is it you did another transaction just before the cancel ? seems to me an error in transactions chaining in the production server (seems list unspent return spent outputs).

Meantime, I just push a commit to re-enable the cancel button if the transaction failed: a priori, wait some minutes and retry the cancel should works.

pryds commented 9 years ago

For me, it happened every time I tried. I even tried again after approximately a day's time, so there shouldn't be any other recent transactions. In the meantime, the order has expired, so I don't know if it's still a problem.

ivanaszuber commented 9 years ago

@ouziel-slama I just created a new order and tried to cancel it and got the same error. So yes, for me it happens every time. The old order is still there with the Cancel button disabled (didn't try a different browser since I got the error on the second order)

ivanaszuber commented 9 years ago

btw, same error appears when trying to issue a new asset (see https://github.com/CounterpartyXCP/counterwallet/issues/730), issue more of the same asset or lock an asset

ouziel-slama commented 9 years ago

OK, this bug should be resolved here: https://github.com/CounterpartyXCP/counterparty-lib/commit/8e3590ee5295cc646793ba8bbbd28bcb79ddb43a

tjoppert commented 9 years ago

I still have the same error when I try to cancel an order using the Counterwallet.io wallet.

failoverAPI: Call failed (failed over across all servers). Method: broadcast_tx; Last error: JSON-RPC Error: Type: Server error

Code: -32000

Message: Bad status code returned: '500'. result body: '{"result":null,"error":{"code":-26,"message":"64: scriptpubkey"},"id":0} '.

Am I forgetting something ?

Extra info: I have about 15 orders open It occurs on every one of them. Multiple pairs.

btcdrak commented 9 years ago

@JopHartog Changes are not rolled out the the counterwallet servers immediately. Usually you have to wait until the next server updates if you arent running your own nodes.

tjoppert commented 9 years ago

@btcdrak Thank you for the clarification, I will try it on my own node.

btcdrak commented 9 years ago

@JopHartog At risk of stating the obvious, remember it's in the develop branch not master.

adamkrellenstein commented 9 years ago

Solved with https://github.com/CounterpartyXCP/counterparty-lib/commit/8e3590ee5295cc646793ba8bbbd28bcb79ddb43a

unsystemizer commented 8 years ago

Users still having issues - https://counterpartytalk.org/t/cannot-cancel-order/1114 Do we need more info? Should we reopen this?

ivanaszuber commented 8 years ago

I just tested this and it seems to be working fine. I was able to cancel an open order without issues

tjoppert commented 8 years ago

The issue was solved. Was trying it on a not updated node.

Best Regards, / Met vriendelijke groet,

Jop Hartog

Phone: +31 (0)628947224 E-mail: info@jophartog.nl Web: www.JopHartog.nl http://www.jophartog.nl PGP: 0x32E40321

On 21 July 2015 at 17:33, Ivana Zuber notifications@github.com wrote:

I just tested this and it seems to be working fine. I was able to cancel an open order without issues

— Reply to this email directly or view it on GitHub https://github.com/CounterpartyXCP/counterwallet/issues/734#issuecomment-123372610 .