Update Bitcore to v0.13.7

CounterpartyXCP / counterwallet

Counterparty web wallet

https://counterwallet.io

147 stars 162 forks source link

Update Bitcore to v0.13.7 #753

Closed rubensayshi closed 8 years ago

rubensayshi commented 8 years ago

depends on https://github.com/CounterpartyXCP/counterwebdeps/pull/7 depends on https://github.com/bitpay/bitcore-lib/pull/12 (or atm uses code from my repo) MERGED

rubensayshi commented 8 years ago

the callbacks throughout the project are a bit funky in some places conserning error handling. for the callbacks in util.bitcore.js I followed the JS standard of doing callback(err, result) where err is NULL for success, so I applied that everywhere util.bitcore.js was used.

rubensayshi commented 8 years ago

merge counterwebdeps bitcore update PR
change the counterwebdeps link bower.json back to CounterXCP repo (and with new commit hash)
grunt freeze to update bowerhashes.json
either wait for bitcore PR or set a commit hash for bitcore in bower.json to rubensayshi/bitcore-lib repo
merge this PR
merge the travis/circle PR

and later move over counterwebdeps into counterwallet

robby-d commented 8 years ago

On an initial view, this looks good to me. Once the bare multisig is merged into bitcore-lib master, can you 1) update the git URI and 2) issue this PR (and the others) against the counterwallet 1.7.0 branch? Then I can merge all of it in, and test further before merging that into develop.

rubensayshi commented 8 years ago

PR for bitcore-lib has been merged

robby-d commented 8 years ago

Closing this due to #758