code style cleanup (no functional changes).

CounterpartyXCP / counterwallet

Counterparty web wallet

https://counterwallet.io

147 stars 162 forks source link

code style cleanup (no functional changes). #760

Closed rubensayshi closed 8 years ago

rubensayshi commented 8 years ago

most of it is done automated (PHPStorm code format). a lot of 4spaces (and even tabs) being replaced, in general missing spaces between if( and params etc.

doesn't hurt to keep it clean imo and it was hurting my eyes when working on stuff :stuck_out_tongue:

robby-d commented 8 years ago

@rubensayshi I'm fine with this, except that the reformating should exclude the following files:

src/js/external/mnemonic.js
src/js/external/qrcode.js
src/js/smartadmin.app.js

Reason being, these come from external sources and I'd rather have their original formatting so they can be more easily diffed to the original (especially mnemonic.js, since it is such an important file to be secure)

rubensayshi commented 8 years ago

I completely agree, I redid the reformatting a few times, must have excidently touched those too during the final attempt.

robby-d commented 8 years ago

Close, can you also remove src/js/smartadmin.app.js as well? (that file was originally copied from the smartadmin admin template counterwallet uses, and I like to be able to easily diff it for when we upgrade smartadmin).