search

CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 162 forks source link

Evaluate asset description length, use pubkeyhash for 42-52 byte long description #810

Closed unsystemizer closed 6 years ago

unsystemizer commented 7 years ago

Counterwallet can't effect asset description change for over 41 bytes.

Somewhere around here (or before), description string length could be evaluated and if > 41 and < 53 bytes, we could set encoding to pubkeyhash.

https://github.com/CounterpartyXCP/counterwallet/blob/542d63f887c70c426b3b62a8deed757db0d63b43/src/js/components/balances.js#L1145

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/40973326-evaluate-asset-description-length-use-pubkeyhash-for-42-52-byte-long-description?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github).
deweller commented 6 years ago

I say let's wait until CIP-6 is enabled and then we can use P2SH data encoding for longer descriptions

deweller commented 6 years ago

Fixed by https://github.com/CounterpartyXCP/counterparty-lib/pull/1005