search

CounterpartyXCP / counterwallet

Counterparty web wallet
https://counterwallet.io
147 stars 162 forks source link

Remove ability to access BTC markets #840

Open loon3 opened 6 years ago

loon3 commented 6 years ago

Since BTCPAY is disabled in the UI, it makes sense to remove the ability to create dex orders with any pair that includes BTC. This will eliminate confusion as to why orders can be created but can't be matched.

image

Typing BTC in the Token 1 or Token 2 field should display an error in the same place as the one displayed above when both tokens are the same. The error could read "BTC trading currently disabled in Counterwallet".

deweller commented 6 years ago

Should we continue to allow users to open orders to sell assets for BTC?

Sites like https://btcpaymarket.com/ could still match the other side that way.

loon3 commented 6 years ago

We shouldn't have half functionality in Counterwallet (unless you want to put a big warning that says "You won't be able to match this order in Counterwallet" which IMO is even more confusing).

Also, Btcpaymarket.com is currently in need of some TLC and not functioning at the moment.

deweller commented 6 years ago

Ok. I'm comfortable with putting an obvious warning here when trying to sell for BTC. But I think we should continue to allow it since it is supported at the protocol level.

And trying to buy with BTC should continue to be blocked.

loon3 commented 6 years ago

The warning should also include that you can't buy with BTC either rather than just blocking it.

Its become a point of confusion for new users, IMO a warning probably won't do much to alleviate that confusion. It's like dangling the carrot on a stick that the user can never get to.