search

Countly / countly-sdk-unity

Countly Product Analytics Unity SDK
https://count.ly/mobile-analytics
MIT License
42 stars 30 forks source link

This package really makes itself home #198

Closed AldeRoberge closed 3 months ago

AldeRoberge commented 5 months ago

Warn your users to NOT import this .unitypackage into their working projects, as this will import files all over the place.

Instead of neatly placing itself into the Plugins/Countly folder like all well-behaved plugins do, this unity package will instead bits and pieces of junk all over your project, including but not limited to :

Please simply aggregate all of your SDK files required to make this work into a simple, neat folder to avoid the headaches of figuring out why importing this broke the hell loose in my project.

image

Thankfully, I was using a dummy project to test and had a VCS enabled.

AldeRoberge commented 5 months ago

Maybe I was a bit harsh here, but clearly the person(s) who made this integration into Unity never actually opened it in their projects. Again the solution is very simple : Move all of your junk files into a subfolder to hide it away and to avoid it mixing with all of your other plugins.

AldeRoberge commented 5 months ago

Digging deeper into the problem this caused in my project, it was due to a .asmdef file at the root of the Plugins folder : image Please renamed this .asmdef into "Countly.Runtime" and move it into the Plugins/Countly/Runtime folder. You can create one for the Editor while youre at it!

AliRKat commented 5 months ago

Hello, Thank you for the feedback and for mentioning these points. We will examine these issues and look into shifting the structure within the next release.

AliRKat commented 4 months ago

Hello, our minor release which contains the shifted structure is out. Feel free to check it out! https://github.com/Countly/countly-sdk-unity/releases/tag/23.12.1