Countly / countly-sdk-unity

Countly Product Analytics Unity SDK
https://count.ly/mobile-analytics
MIT License
42 stars 30 forks source link

Record close view bug fix #221

Closed AliRKat closed 1 month ago

AliRKat commented 1 month ago

Bug: It was possible to call RecordCloseViewAsync with a ''valid'' view name, even if it doesn't exist. It would record a close-view event for the view that's never started.

The offered solution is, without changing core functionality and causing anything to break, we have added the viewdata structure in RecordOpenViewAsync and checked the view id in RecordCloseViewAsync to make sure we return if there's no view with that id

AliRKat commented 1 month ago

[Unity] RecordCloseViewAsync has TODO: this performs in a non standard way. It should only be possible to close started views.