search

Countly / countly-sdk-unity

Countly Product Analytics Unity SDK
https://count.ly/mobile-analytics
MIT License
42 stars 30 forks source link

UserDetailsCountlyService Deprecation #223

Closed AliRKat closed 3 months ago

AliRKat commented 3 months ago

The final decision we made with @turtledreams was to deprecate this class because its methods do not follow our naming conventions in other SDKs. Functionality-wise, UserProfile rework will happen in the following PR.

Because of these reasons, in this PR, I've created Legacy folders for both Tests and Services and moved related code to those folders. This PR still also contains the refactoring for the Legacy tests.

AliRKat commented 3 months ago

[Unity] Rework Legacy Tests

AliRKat commented 3 months ago

[Unity] Switch "UserDetailsCountlyService" to interface

AliRKat commented 3 months ago

moved consent checks and internal calls into this PR https://github.com/Countly/countly-sdk-unity/pull/225

After merging it, i will continue rework here afterward, which will reduce the total lines changed and give us a healthier thing to work on

AliRKat commented 3 months ago

there were few tests that could have been shortened with using TestCase which i did, also 1 test was an exact duplication of another. those are the ones that look like deleted, other than those we are keeping the test functionality. if wished we can bring back that exact duplication one :) no need for the test case ones since they are still in there @arifBurakDemiray

when we finalise changes in internal call and consent checks PR for user properties, that one will be merged into here to continue