search

Countly / countly-server

Countly is a product analytics platform that helps teams track, analyze and act-on their user actions and behaviour on mobile, web and desktop applications.
https://countly.com
Other
5.57k stars 972 forks source link

[Fixes for China] Google Maps in Geolocations #183

Closed osoner closed 5 years ago

osoner commented 9 years ago

Well, the issue is obvious. Google Maps doesn't work in China so geolocations doesn't work either. Not really sure how to proceed here, Bing Maps? or configurable Baidu Maps option @iartem?

image

tianshuo commented 8 years ago

Hi, could someone first fix the jquery cdn issue? That is top priority for us.

iartem commented 8 years ago

What issue are you referring to?

osoner commented 8 years ago

Hi, I think @tianshuo is referring to the fact that javascript file for the map is loaded from a CDN. Unfortunately the fix for this is not hosting the file locally. Google doesn't allow this and even if we can host it locally the script will still make calls to Google servers.

We started changing the world visualisation to DataMaps and will find a similar fix for push geolocations as well.

Sorry for the inconvenience and thanks for your patience!

jianglinchun commented 8 years ago

I'm working on echarts of Baidu. http://echarts.baidu.com/doc/example/map1.html http://echarts.baidu.com/doc/example/map4.html I'll share the code ASAP.

tianshuo commented 8 years ago

I created a new issue ( #211 ) for what I mentioned previously. If provinces in China is supported, that would be great.

osoner commented 8 years ago

@jianglinchun did you have any chance to complete eCharts support?

jianglinchun commented 8 years ago

@osoner I'm busy with my jobs now. And I'd successfully developed a new plugin which used echarts. I may submit the pull requests within 1-2 month.

jianglinchun commented 8 years ago

@osoner I had fix the problem. But I'm not sure UE and the code guideline. Or should I and a switch to the config?

gorkem-cetin commented 8 years ago

@jianglinchun can we have a skype telco for this if you are done with your plugin? :) That would be really great if we can come up with a solution that can be used for China, and include it in next release if you are also comfortable with that.

Awaiting for your reply.

jianglinchun commented 8 years ago

@gorkem-cetin thank you for your attention. I'd checkout the latest countly branch and I found a google service switch was added to the config panel. So I thought I should modify my code and use the switch value to decide when to switch to echarts. And my skype id: jianglinchun@live.com :)

gorkem-cetin commented 8 years ago

That exactly would work like that, unless @ar2rsawseen has another idea.

ar2rsawseen commented 8 years ago

Yes, the check for setting is actually quite simple: https://github.com/Countly/countly-server/blob/master/plugins/mobile/frontend/public/javascripts/countly.views.js#L16

jianglinchun commented 8 years ago

please check this pull request: https://github.com/Countly/countly-server/pull/273

jianglinchun commented 7 years ago

Please use the solution from baidu officially. http://lbsyun.baidu.com/index.php?title=open/move