search

Coursemology / coursemology2

Rails 6 re-write of Coursemology
https://coursemology.org
MIT License
147 stars 78 forks source link

Prevent students from deleting discussion posts #1906

Open kxmbrian opened 7 years ago

kxmbrian commented 7 years ago

Arsing from this comment from #882

I actually think posts should not be deleted, it will break the context and reparent won't help. Most of the forums I used do not allow normal user to delete their posts.

benleong commented 7 years ago

I disagree. Mistakes happen. Please allow this.

On Tue, Jan 17, 2017 at 11:19 AM, Brian Koh notifications@github.com wrote:

Arsing from this comment https://github.com/Coursemology/coursemology2/issues/882#issuecomment-210309104

I actually think posts should not be deleted, it will break the context and reparent won't help. Most of the forums I used do not allow normal user to delete their posts.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Coursemology/coursemology2/issues/1906, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPMdaWQMzYJrqCt9xFjk99SG4-4SBf8ks5rTDMsgaJpZM4LlMC0 .

benleong commented 7 years ago

You can create a module setting that allows the instructor to disable it though.

On Tue, Jan 17, 2017 at 11:21 AM, Ben Leong benleong@comp.nus.edu.sg wrote:

I disagree. Mistakes happen. Please allow this.

On Tue, Jan 17, 2017 at 11:19 AM, Brian Koh notifications@github.com wrote:

Arsing from this comment https://github.com/Coursemology/coursemology2/issues/882#issuecomment-210309104

I actually think posts should not be deleted, it will break the context and reparent won't help. Most of the forums I used do not allow normal user to delete their posts.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Coursemology/coursemology2/issues/1906, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPMdaWQMzYJrqCt9xFjk99SG4-4SBf8ks5rTDMsgaJpZM4LlMC0 .

allenwq commented 7 years ago

@benleong How about only allowing deletion in a short period after the post is created (let's say 30min ?). Because If we are not sure who will benefit from the feature, it might not be a good idea to create a new option and implement/maintain it.

The problem is that I heard from tutors that some students delete their questions in the forum after they get the answer, then it looks like a group of people reply to an empty thread.

benleong commented 7 years ago

Sorry I forgot to respond. How about questions with posts cannot be deleted. Only questions with not posts can be deleted.

allenwq commented 7 years ago

👍 That works too.