SVG Parser: Use Dimensions Of Input Graph

Courseography / courseography

Courseography is a tool created by David Liu and Ian Stewart-Binks to guide students through their undergraduate careers.

GNU General Public License v3.0

59 stars 65 forks source link

Open Ian-Stewart-Binks opened 9 years ago

Ian-Stewart-Binks commented 9 years ago

The SVG parser currently has the dimensions of the output graph hardcoded in. This should be taken from the input graph.

Note that this likely means that the database will need to know this information.

david-yz-liu commented 9 years ago

This is correct, although we should probably also specify some "standard size" to act as a guideline.

Ian-Stewart-Binks commented 9 years ago

Something along the lines of having upper bounds on the dimensions?

We will need to coordinate this with the drawing tool, as well.

david-yz-liu commented 9 years ago

So, a checklist:

[ ] Update the Wiki graph-creation instructions to have the users check for a maximum document size
[ ] Update SVG parser to get the width and height attributes of the SVG file
[ ] Update the SVG Generator so that it uses the custom width and height for each graph