Courseplay / Courseplay_FS22

Courseplay for Farming Simulator 2022
GNU General Public License v3.0
843 stars 179 forks source link

[Feature] Change the Way Combines Return to Fruit in Field #2519

Closed lcc1211 closed 1 year ago

lcc1211 commented 1 year ago

What is the problem this feature/enhancement solves? Using a combine with a large header, and the header is "in the fruit" CP currently stops the combine, reverses it back & away from the fruit. This part is excellent and allows the tractor to pull right up and offload. However, when the combine returns to the fruit, it typically misses a portion on the far right of the header.

Describe the solution you'd like I'd like the combine to move back to the fruit as it does now, but instead of immediately lowering the header and continuing on, the combine should reverse about 5 meters, lower the header and then carry on. From my experience this would eliminate the majority of the fruit being left behind.

Describe alternatives you've considered It is really hit or miss and I'm not sure which header size generally works best because it seems to also depend on how agile the combine is, but generally, I don't see fruit left behind by headers that are under 10 meters in width.

Additional context This is how CP does it now: https://drive.google.com/file/d/1VQf4eUN1ndCsPugc7SqmvBiaskFNl1vC/view?usp=share_link This is my suggestion: https://drive.google.com/file/d/1u4FleNrv4cxMrUocICD-oq-QLM1JyThr/view?usp=share_link

Tensuko commented 1 year ago

What Combine, what header. Example Screenshot?

lcc1211 commented 1 year ago

Basically, the larger headers of 10+ meters. I'm trying to upload a video and link here so you'll see an example. At the moment I seem to be unable to get to Gmail, YouTube or any other Google product. Once that clears up, I'll have 2 videos to share.

lcc1211 commented 1 year ago

In the links I added above, I'm using the Modhub version of the Class Convio 1380 header (13.8M) with the Class Lexion 8900 combine. However, the combine and header are agnostic here as width of the header seems to be the determining factor. To be sure of this, I also used a smaller header of 7.6 meters which left no fruit behind. I also used the Modhub New Holland 10.90 with the 14.7M draper header and it also leaves fruit behind.

Tensuko commented 1 year ago

Not that simple as you imagine, but I get your Idea. Will figure something out.

pvaiko commented 1 year ago

Moving back a little further may help, you can adjust the constant at https://github.com/Courseplay/Courseplay_FS22/blob/88956b6980ec85982137f8bbe19c10403ea7532e/scripts/ai/AIDriveStrategyCombineCourse.lua#LL137C1-L137C1

lcc1211 commented 1 year ago

I may have misunderstood @pvaiko 's reply. Was I to change a line in one my files?

Tensuko commented 1 year ago

Yea and try it out if that does help you.

lcc1211 commented 1 year ago

I'll try adjusting in increments of 1 and see if there is a best number. Bare with me since my friends and I are playing a marathon session, so it will most likely be a day or 2.

lcc1211 commented 1 year ago

I apparently do not know what I'm doing. I unzipped the CP file and updated the line you highlighted. Then I zipped it back up and put it back in the MOD folder. I got the prompt asking if I wanted to overwrite the CP file and I selected YES. However, when I try to launch FS, it tells me CP is missing.

pvaiko commented 1 year ago

No need to zip it back up, you can just put the unzipped folder under mods so you have everything unzipped in mods\FS22_Courseplay and make the changes directly there.

lcc1211 commented 1 year ago

I'm sorry to report that upping the number to 2, 3 and 4 made no difference. The combine still moves up to near the work start line and turns in sharply missing the same bit of fruit.

pvaiko commented 1 year ago

Thanks for checking it out. We'll figure out something else.

coatsy35 commented 1 year ago

Any chance when it creates the unloading pocket, it can stop before it reverses to empty the straw out - like what happens now at the end of a run which is great. As currently when creating pockets it creates "arcs" of straw each time

lcc1211 commented 1 year ago

Any chance when it creates the unloading pocket, it can stop before it reverses to empty the straw out - like what happens now at the end of a run which is great. As currently when creating pockets it creates "arcs" of straw each time

Isn't it better to avoid large piles of straw, though?

coatsy35 commented 1 year ago

Any chance when it creates the unloading pocket, it can stop before it reverses to empty the straw out - like what happens now at the end of a run which is great. As currently when creating pockets it creates "arcs" of straw each time

Isn't it better to avoid large piles of straw, though?

IRL when I was driving a combine, you would back up and lay the straw over the row a little way until it stopped coming out so you didn’t create a pile for the baler. However since CP has decided no to do that and just stop at the end of a row so it doesn’t make arcs out the end of the row (like it did a few months ago) it would be good if it did the same when creating a pocket. Unless they wish to make it more realistic and make it back up to overlay instead as an addition which would be cool, but might not be possible