Courseplay / courseplay

Courseplay for Farming Simulator 2019
http://courseplay.github.io/courseplay
GNU General Public License v3.0
954 stars 529 forks source link

Curseplay and Drive control #1893

Closed NarvenEugen closed 7 years ago

NarvenEugen commented 7 years ago

I noticed such a thing that if the driver of the tractor, for example, when plowing starts to slip (option always use 4x4 included), then the driver does not include the differential lock provided by Drive control, as it was in the version of the farming simulator 2015. And if the locking differentials include the Then start the driver, then he turns them off himself. It would be convenient for the driver himself to include blocking of differentials or at least not to disconnect them

Satissis commented 7 years ago

Added as an suggestion for now as we are busy working on other stuff (The list is long)

NarvenEugen commented 7 years ago

Thank you

Satissis commented 7 years ago

We had an talk about this one a day or 2 ago, and the diff lock is already implemented. It's automatic thou and works like this: If 4wd is turned on and the tractor is slipping for 6 sec, it will turn the difflock on as well and turn it off again once it's not slipping again for a time.

Can we close here again then ?

genen commented 7 years ago

I don't understand why can't you leave the dif lock on if it is triggered by slippage... I am constantly having to hit ctr 7, turn on all 3 locks, manually hit gas, then hit ctr 7 again... this happens 10-20 times per play period as tractors have some wheels with less traction on turns. Literally, all it would take to prevent having to manually take control is for you to REMOVE some code (which turn the diff off again) so should be super simple. The auto off right now is way too short... so on many maps I see a sort of pulsing of the tractor where it turns on locks, moves a tiny bit, turns off locks, rolls back a bit, over and over... if you detect slipping, and turn all the locks on in response, leaving them on for the rest of that job would prevent slowdowns and need for manual control.

Satissis commented 7 years ago

I don't use DC my self, since I want to test without too many mods on, but Thomas have been using DC since day 0 of that mod and he don't really have any problems with it.

What vehicle and tool setup are you using since you lose so much traction on turns ?

genen commented 7 years ago

Happens pretty regularly... I'll record a few instances in the video for you... Any map that is not flat will result in a tractor changing direction on a hill usually, the uphill wheels will spin slowing or stopping it. Usually the tractor pulling a tipper

NarvenEugen commented 7 years ago

Just checked. Does not include differential locks. Specially put the tractor on the pole and made it slip ... 20 seconds slipped and there was not even an attempt to engage the differential lock Yes forgot to say - the regime was fertilizing and sowing

pops64 commented 7 years ago

Seems to work fine for me. Debug channel 14 if your having issues working the way it currently is setup plus a picture

farmingsimulator2017 64bit 4_1_2017 12_04_00 pm

genen commented 7 years ago

https://youtu.be/TyhCmh6mJEk

pops64 commented 7 years ago

Need a log. with just debug channel 14. The fuel flow mod is covering up the outputs from Drive Control showing what status are the 4wd and difflocks are in

NarvenEugen commented 7 years ago

I do not speak English, so you can tell me how to make the report I need?

genen commented 7 years ago

video at https://youtu.be/as1silhFHcs log - Copy (2).txt dataS2/character/pedestrians/woman06.i3d (52.60) ms dataS2/character/pedestrians/man06.i3d (2.71) ms dataS2/character/pedestrians/man01.i3d (2.50) ms dataS2/character/pedestrians/man02.i3d (3.21) ms [dbg14 lp29434] GTXM Big M (#1): curStage=2, refSpeed=10.00, curSpeed=2.33 -> setSlippingStage 1 [dbg14 lp29434] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp29440] GTXM Big M (#1): setCustomTimer(..., "slippingStage2", 3) [dbg14 lp29446] GTXM Big M (#1): curStage=1, refSpeed=10.00, curSpeed=2.55 -> resetCustomTimer(..., "slippingStage2") [dbg14 lp29463] GTXM Big M (#1): setCustomTimer(..., "slippingStage2", 3) [dbg14 lp29573] GTXM Big M (#1): timerIsThrough(..., "slippingStage2") -> setSlippingStage 2, reset timer [dbg14 lp29573] GTXM Big M (#1): setSlippingStage(..., 2) [dbg14 lp29598] GTXM Big M (#1): curStage=2, refSpeed=10.00, curSpeed=2.31 -> setSlippingStage 1 [dbg14 lp29598] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp29605] GTXM Big M (#1): curStage=1, refSpeed=10.00, curSpeed=3.70 -> setSlippingStage 0 [dbg14 lp29605] GTXM Big M (#1): setSlippingStage(..., 0) [dbg14 lp29654] GTXM Big M (#1): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp29745] GTXM Big M (#1): timerIsThrough(..., "slippingStage1") -> setSlippingStage 1, reset timer [dbg14 lp29745] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp29746] GTXM Big M (#1): setCustomTimer(..., "slippingStage2", 3) [dbg14 lp29836] GTXM Big M (#1): timerIsThrough(..., "slippingStage2") -> setSlippingStage 2, reset timer [dbg14 lp29836] GTXM Big M (#1): setSlippingStage(..., 2) [dbg14 lp29852] GTXM Big M (#1): curStage=2, refSpeed=10.00, curSpeed=2.13 -> setSlippingStage 1 [dbg14 lp29852] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp29860] GTXM Big M (#1): curStage=1, refSpeed=10.00, curSpeed=3.63 -> setSlippingStage 0 [dbg14 lp29860] GTXM Big M (#1): setSlippingStage(..., 0) [dbg14 lp29928] Terra Variant 600 eco (#3): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp29939] Terra Variant 600 eco (#3): curStage=0, refSpeed=10.00, curSpeed=3.82 -> resetCustomTimer(..., "slippingStage1") [dbg14 lp30165] TORUM 760 (#2): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp30216] GTXM Big M (#1): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp30248] TORUM 760 (#2): curStage=0, refSpeed=3.00, curSpeed=1.11 -> resetCustomTimer(..., "slippingStage1") [dbg14 lp30306] GTXM Big M (#1): timerIsThrough(..., "slippingStage1") -> setSlippingStage 1, reset timer [dbg14 lp30306] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp30307] GTXM Big M (#1): setCustomTimer(..., "slippingStage2", 3) [dbg14 lp30373] TORUM 760 (#2): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp30386] TORUM 760 (#2): curStage=0, refSpeed=10.00, curSpeed=3.60 -> resetCustomTimer(..., "slippingStage1") [dbg14 lp30397] GTXM Big M (#1): timerIsThrough(..., "slippingStage2") -> setSlippingStage 2, reset timer [dbg14 lp30397] GTXM Big M (#1): setSlippingStage(..., 2) [dbg14 lp31041] GTXM Big M (#1): curStage=2, refSpeed=10.00, curSpeed=3.36 -> setSlippingStage 1 [dbg14 lp31041] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp31042] GTXM Big M (#1): curStage=1, refSpeed=10.00, curSpeed=4.40 -> setSlippingStage 0 [dbg14 lp31042] GTXM Big M (#1): setSlippingStage(..., 0) [dbg14 lp31121] GTXM Big M (#1): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp31211] GTXM Big M (#1): timerIsThrough(..., "slippingStage1") -> setSlippingStage 1, reset timer [dbg14 lp31211] GTXM Big M (#1): setSlippingStage(..., 1) [dbg14 lp31212] GTXM Big M (#1): setCustomTimer(..., "slippingStage2", 3) [dbg14 lp31316] GTXM Big M (#1): timerIsThrough(..., "slippingStage2") -> setSlippingStage 2, reset timer [dbg14 lp31316] GTXM Big M (#1): setSlippingStage(..., 2) [dbg14 lp32960] Terra Variant 600 eco (#3): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp33054] Terra Variant 600 eco (#3): timerIsThrough(..., "slippingStage1") -> setSlippingStage 1, reset timer [dbg14 lp33054] Terra Variant 600 eco (#3): setSlippingStage(..., 1) [dbg14 lp33054] Terra Variant 600 eco (#3): set fourWheel to true [dbg14 lp33055] Terra Variant 600 eco (#3): setCustomTimer(..., "slippingStage2", 3) [dbg14 lp33066] Terra Variant 600 eco (#3): curStage=1, refSpeed=29.00, curSpeed=6.18 -> resetCustomTimer(..., "slippingStage2") [dbg14 lp33071] Terra Variant 600 eco (#3): curStage=1, refSpeed=29.00, curSpeed=10.56 -> setSlippingStage 0 [dbg14 lp33071] Terra Variant 600 eco (#3): setSlippingStage(..., 0) [dbg14 lp33165] GTXM Big M (#1): setSlippingStage(..., 0) [dbg14 lp33204] Terra Variant 600 eco (#3): set fourWheel to false [dbg14 lp33347] Terra Variant 600 eco (#3): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp33366] Terra Variant 600 eco (#3): curStage=0, refSpeed=24.00, curSpeed=8.52 -> resetCustomTimer(..., "slippingStage1") dataS2/character/pedestrians/woman04.i3d (3.33) ms [dbg14 lp33416] GTXM Big M (#1): set diffLockFront to false [dbg14 lp33416] GTXM Big M (#1): set diffLockBack to false [dbg14 lp34163] GTXM Big M (#1): setCustomTimer(..., "slippingStage1", 3) [dbg14 lp34193] GTXM Big M (#1): curStage=0, refSpeed=20.00, curSpeed=7.05 -> resetCustomTimer(..., "slippingStage1")

genen commented 7 years ago

My easy fix suggestion is to get rid of the timer 2, and and just leave all diffs locked if it EVER slips...

pops64 commented 7 years ago

No that would not do a single thing because looking through you log for what ever reason CP is not engaging drive control with GTXM Big M. If you didn't have the fuel flow mod enabled you would see CP not engaging drivecontrol for this mod vehicle. Under the speed limits tab you should see an option for always use 4wd

Looked through your log again. You need to start debug channels before you encounter a bug not while encountering a bug has there is usually stuff that could be printed that would be helpful. The diff locks where engaged for the whole duration of the log. So it seems that the vehicle in question is not capable of driving over bales while under CP control assuming it is engaing the difflocks in the first place. @NarvenEugen in the settings tab at the bottom you will see debug channels line if you hit the down arrow next to it that will show you the next row. Hit the 14 button and then run CP. Follow theses instructions on how to post it https://github.com/Courseplay/courseplay/wiki

farmingsimulator2017 64bit 4_5_2017 1_37_14 am

@genen Has shown in the above pic this mod + CP + drivecontrol are all working properly. So you must be having some other kinda of issue and judging by you log it is most likely another mod. The set difflock to true is missing from you log. So you either are interrupting CP from changing this is or there is interference from a different mod

NarvenEugen commented 7 years ago

In beta version 5.01.00115 the problem is gone

genen commented 7 years ago

Watch the video... dif locks were NOT engaged until I stopped CP manually enables and then could drive.

I'll try v 5.01.00115 and let you know

pops64 commented 7 years ago

0115 should not change this bug. As it only dealt with mode8 behavior. Try disabling mods as this is probably a mod conflict with something else. Start with anything that mods the speed values of your vehicle. As I saw a non standard speed display in your video. Because it works when only CP + drive control and your mod vehicle are involved.

pops64 commented 7 years ago

I will close tthis out since I can not reproduce this and in my tests works. Post here if you have steps on how to produce this.