Courseplay / courseplay

Courseplay for Farming Simulator 2019
http://courseplay.github.io/courseplay
GNU General Public License v3.0
953 stars 528 forks source link

Keeping constant speed even when recorded with another speed #3067

Closed Fogest closed 5 years ago

Fogest commented 5 years ago

When I record a route to transfer hay/straw I have collected from the ground with a loading wagon, it does not seem to do anything at the unload point when it reaches it during my recording. It just continues driving and never actually does any unloading. I want it to unload my straw/hay when it backs into the unload point at the barn.

Here is the log for v6.01.00020.dev (debug channels 1, 2, 12, and 14 on):

https://pastebin.com/bjjQAfA4

To make things even more clear I used Windows Game Recording feature and uploaded a clip of me recording the route, and running the route with the debug channels 1, 2, 12, and 14 on (this is where the log came from too):

https://xboxdvr.com/gamer/duel-machinegun/video/68484208

SirStranger1989 commented 5 years ago

I believe you should hit the pause button, not the unload button. At least that's how it worked in fs17.

Fogest commented 5 years ago

I believe the pause button just makes it wait for you to press "Drive on" doesn't it? What would the unload one do then?

On Thu, Jan 31, 2019, 7:34 PM SirStranger1989 <notifications@github.com wrote:

I believe you should hit the pause button, not the unload button. At least that's how it worked in fs17.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Courseplay/courseplay/issues/3067#issuecomment-459561330, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHBbGaziSMrYeK3O4-VS6lPXhd0XzKgks5vI4uvgaJpZM4adV-p .

SirStranger1989 commented 5 years ago

Hang on, my bad. I was thinking about unloading bales.

Unloading straw should work without an manual unload command. Once cp reaches the unload trigger it should start unloading. Just drive in a bit further and hit reverse again.

SirStranger1989 commented 5 years ago

Oh and you left it in the wrong mode. That one, indeed, only drives from start to stop. First mode is for unloading.

Fogest commented 5 years ago

Yeah that worked. Only weird thing is how it drives like a granny the whole time despite as you see in the original recording I did not drive that slow the whole time :).

Log: https://pastebin.com/MPJ66q1r Video: https://xboxdvr.com/gamer/duel-machinegun/video/68501482

Fogest commented 5 years ago

I did a much longer route that came from my field quite farther away to the barn and it also has the same thing happening with driving a slow speed. It's driving at a constant 16kph the whole way which is odd as the turn speed is 10, field speed 24, street automatic, reverse 6, and speed from recording. None of those speeds should be stuck at 16 the whole way.

The above logs on the shorter route should still reflect this issue along with the video showing it.

Edit: It does the speeds correctly when doing the turns/reversing and such, it's just when it's driving normally that it seems stuck at such a speed.

Satissis commented 5 years ago

Right, looks like you got it to work. Here are some hints for you as well.

  1. Yes the need of an manual unload point is not needed in mode 1.
  2. The reversing speed is limited to what is set in the speed setting for reversing.

Now for the last post you did where it only ran at max 10km/h, I'm a bit unsure of why it's doing that and might be something @pvajko have to look into (Or who ever have the time for it)

Fogest commented 5 years ago

What is the best way to use a loading wagon to pickup material from the field and then when full take it to the barn drop off? I assumed having it on field work mode, generate the course for the field, then append the course to drop off at the barn would be the correct procedure? However this seems to not work properly.

Maybe this aspect is simply not added yet though I could be incorrect thinking is or maybe doing it wrong?

On Fri, Feb 1, 2019, 4:35 AM Claus G. Pedersen <notifications@github.com wrote:

Right, looks like you got it to work. Here are some hints for you as well.

  1. Yes the need of an manual unload point is not needed in mode 1.
  2. The reversing speed is limited to what is set in the speed setting for reversing.

Now for the last post you did where it only ran at max 10km/h, I'm a bit unsure of why it's doing that and might be something Peter have to look into (Or who ever have the time for it)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Courseplay/courseplay/issues/3067#issuecomment-459662466, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHBbB1nnk5vdStthCnApjiBlxLsBNikks5vJAplgaJpZM4adV-p .

Fogest commented 5 years ago

And just to clarify, on the long routes even to drop off the material at the barn it's driving max at 16kph for some reason. The entire duration of the trip. Only when on the first mode which is the one needed for it to dump.

On Fri, Feb 1, 2019, 4:35 AM Claus G. Pedersen <notifications@github.com wrote:

Right, looks like you got it to work. Here are some hints for you as well.

  1. Yes the need of an manual unload point is not needed in mode 1.
  2. The reversing speed is limited to what is set in the speed setting for reversing.

Now for the last post you did where it only ran at max 10km/h, I'm a bit unsure of why it's doing that and might be something Peter have to look into (Or who ever have the time for it)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Courseplay/courseplay/issues/3067#issuecomment-459662466, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHBbB1nnk5vdStthCnApjiBlxLsBNikks5vJAplgaJpZM4adV-p .

Satissis commented 5 years ago

Yeah. When using it in the field to pickup straw and drop it off at the barn, then you need to use the Fieldwork mode. First record your unload route like above and save it. Then clear the course and either generate the field course or load an already existing one and then load the unload course after it so you combine those 2 courses. That should be it for making it work in fieldwork mode.

But again the speed thing is something we will have to look into I believe as what I saw from the videos, all settings is set correct and should make it go faster in forward and slower in reverse.

game455 commented 5 years ago

Speed setting of cruise control limits driving speed, regardless of recorded speed

sootysax commented 5 years ago

if your course is running slowly, try increasing the cruise control limit... somehow its being limited by that and you can crank it up to maximum and CP will work normally

Fogest commented 5 years ago

Yeah that may have been the issue. It looks like sometimes the cruise control is being bugged from CP and it is getting setting to lower values sometimes. I never actually manually lower the cruise control speed, I always have it set to max but I have noticed that it has gotten set to lower sometimes after being done a CP route.

AtlAntA118 commented 5 years ago

What is the best way to use a loading wagon to pickup material from the field and then when full take it to the barn drop off? I assumed having it on field work mode, generate the course for the field, then append the course to drop off at the barn would be the correct procedure? However this seems to not work properly. Maybe this aspect is simply not added yet though I could be incorrect thinking is or maybe doing it wrong? On Fri, Feb 1, 2019, 4:35 AM Claus G. Pedersen @.*** wrote: Right, looks like you got it to work. Here are some hints for you as well. 1. Yes the need of an manual unload point is not needed in mode 1. 2. The reversing speed is limited to what is set in the speed setting for reversing. Now for the last post you did where it only ran at max 10km/h, I'm a bit unsure of why it's doing that and might be something Peter have to look into (Or who ever have the time for it) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3067 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHBbB1nnk5vdStthCnApjiBlxLsBNikks5vJAplgaJpZM4adV-p .

Im doing it the same way you are doing it and sometimes it unloads the very first time it passes the unload but never a second time. It just goes back to where it was on the field and sits there or does the unloading route again. Will try the .29 version now to see if it fixed things.

AtlAntA118 commented 5 years ago

Looks like recorded courses get stuck to the set turning speed every second run or so. You can just adjust the turning speed to make the ai go faster but then it will overshoot unload/tip triggers because for some reason driving speed over triggers is the same as turning speed.

Edit: the "tip trigger reached" message doesn't go away after the second tipping attempt (first tipping event worked fine) can be fixed by restarting the worker to a nearby way point. Same error occurs after the second tipping attempt though.

Edit2: version.34. BTW

pvaiko commented 5 years ago

@ThomasGaertner do you want to take a look at this, looks like we are somehow stuck in the trigger,

ThomasGaertner commented 5 years ago

does anyone have an savegame and courses for me to replicate it ?

Fogest commented 5 years ago

@ThomasGaertner The issue I had initially described where my cruise control was getting stuck on a lower value and then being used during the course no longer seems to be happening and I believe one of the fixes in here had resolved it. Maybe @AtlAntA118 however can produce a savegame for the issue he is getting related to this.