Courseplay / courseplay

Courseplay for Farming Simulator 2019
http://courseplay.github.io/courseplay
GNU General Public License v3.0
952 stars 527 forks source link

Option to use or not use fertilizer function of seeder missing? #3443

Closed sootysax closed 5 years ago

sootysax commented 5 years ago

There is no option to use the Stara Ceres Master 3570 seeder without the fertlizer function as there is with other seeders that fertilize.

Actually - it seems like that option to either use or not use the fertilizer function of a seeder has disappeared from CP all together? Did it get removed?

pvaiko commented 5 years ago

But you have the convoy instead, don't you? :)

RUGhost commented 5 years ago

Please bring fertilizer function back.

sootysax commented 5 years ago

But you have the convoy instead, don't you? :)

Are they mutually exclusive?

ThomasGaertner commented 5 years ago

@sootysax nope, but they use the same place in the HUD

cyberndj commented 5 years ago

I was looking at it. I see that row 2 is open. There is also some rows open under the Drive Settings page. Which spot seems more logical to have the Fert function reside at?

pvaiko commented 5 years ago

I'd leave it on the same page. Not ruse row 2 is really open isn't that where we show 'Continue' when stopped at a waitpoint?

ThomasGaertner commented 5 years ago

Maybe we can use HUD page 7 for the convoy stuff

cyberndj commented 5 years ago

I'll try putting it there when I get home from work tonight.

cyberndj commented 5 years ago

Hi, I was looking into this more and have an update. I managed to bring back the fert option and keep Convoy active. I was attempting to follow @ThomasGaertner suggestion to move convoy to page 7, but I couldn't get past the loading screen (error messages at bottom).

I moved ridgemarkers to row 2. I know that stomps out "Continue." I was looking at moving it to column 2 next to "Drive Now" and change the row assignments of 2 and 3. (I ran out of time last night) Some other thoughts I had for this are:

FInally, should I do a pull request with this temporary sloppy fix and open another issue for a better fix?

fsScreen_2019_03_21_23_15_05 fsScreen_2019_03_21_23_14_29 fsScreen_2019_03_21_23_14_29 - Copy 2019-03-21 21:50 C:/Users/Jake/Documents/My Games/FarmingSimulator2019/mods/combineUnload_management/CpManager.lua:1077: attempt to call method 'getFullPx' (a nil value) 2019-03-21 21:52 Info: Failed to request rc, HTTP code 0

ThomasGaertner commented 5 years ago

Well since there is a question for making the distance adjustable, I would prefer the page 7 thing. I will check it next week . Thanks for the effort

cyberndj commented 5 years ago

Hi, I managed to get Convoy over to page 7. I see that the sower with fert option is back under page 1. I did notice that the fert option will force convoy to be activated/deactivated opposite to the fert function being active/deactive. I will create a seperate issue for this.

To do so, I had to move The course copy icon on page 7 from Row 8 over to Row 7, column 3. I personally don't use this feature in CP, so could we get some validation this didn't break.

I also set it up so Convoy will show the Activate/Deactivate settings only if the engine is not Driving. If its driving, it will show the follow distance/ convoy member info. I'm going to create the pull request with how these snips show. 3443 Convoy ActiveDeactive 3443 Convoy Driving 3443 Copy Course

ThomasGaertner commented 5 years ago

Hmm please give me the time to check it. Will do it next week

cyberndj commented 5 years ago

Hmm please give me the time to check it. Will do it next week

Thanks! I claim to be a 'beginner' at this coding thing, so I'll take all the review I can get.

ThomasGaertner commented 5 years ago

I'm on it but will close here...