Courseware / buddypress-courseware

BuddyPress Courseware

http://buddypress.coursewa.re

GNU General Public License v2.0

121 stars 34 forks source link

The best of the forks #123

Closed christianwach closed 10 years ago

christianwach commented 10 years ago

121 prompted me to create this overdue PR. See explanation there.

stas commented 10 years ago

OMG, please give me some time to take a look before we merge this :pray:

christianwach commented 10 years ago

@stas Sorry, I should have copied what I said on Twitter in here:

https://twitter.com/interactivist/status/519160895248023552

Please consider this PR a bookmark for my branch!

stas commented 10 years ago

I left a couple of suggestions. Overall I think this is good to merge! Since the biggest changes are relevant to the standalone feature, I think we can continue with the current approach to handle the ACL and groups support and consider changing that in nearest future with a more pragmatic alternative.

Huge thanks to @iandunn @christianwach @sboisvert and @16nsk

@lloc, @mamaduka, if you have suggestions, please leave a comment, otherwise I will consider this as good to merge.

lloc commented 10 years ago

It would be fine for me.

christianwach commented 10 years ago

@stas Thanks for reviewing the PR. Look forward to following development!

Mamaduka commented 10 years ago

@stas thanks for merging this PR.