Courtney513 / jason-pearson-web-project

0 stars 0 forks source link

Semantics #1

Open am548726 opened 9 years ago

am548726 commented 9 years ago

Semantics

Naming Conventions

Your html outline seems good but checking in https://gsnedders.html5.org/outliner/ your first level and first sub-level should be switched since the website is about Jason Pearson.
Since you are using placeholder images in your prototype when it comes to naming conventions one example that Ella provided us was hero-lg-ball.jpg or icon-lg-facebook.svg.

MatthewCThompson commented 9 years ago

There are some css classes I thought could be given more meaning. For example, "button round" could be "rounded-button" unless i missed were "round" was used a second time or that was brought in.

elladurham commented 9 years ago

I'd say the bigger issue with "button round" is that it is describing a visual property. Using things like button-primary button-secondary button-call-to-action are much better choices for naming buttons because they may change visually in the future, what happens if you or a future designer decide not to make them round anymore?