search

Courtney513 / jason-pearson-web-project

0 stars 0 forks source link

Cleanliness of Code #6

Open Valerie-Wissenburg opened 9 years ago

Valerie-Wissenburg commented 9 years ago

HTML: Everything looks pretty good so far but one thing is that you guys have a stry div tag on line 76.

CSS: My question is what's the commented css all about? Do you need it? I know you don't know but what is the relevance for the code? Actually I don't think you need it at all. It seems to look like redundant css. You've covered everything already.

Valerie-Wissenburg commented 9 years ago

One thing I'd say in your HTML is that it's okay to give your sections a little breathing room so it's easier to read. Another something if you forgot– you don't have to spell out the classes with all those pesky vowels. buttons could reduce to btns. (such as line 43 ,138) Looking through this as well is that I've noticed that you guys used button round classes together and so it might also help to combine those classes to one class. So you don't have to separate classes. (Although I haven't looked at your CSS for these classes so they might not match) Just an idea :)

Valerie-Wissenburg commented 9 years ago

CSS: Just one more quick thing, you have a little wonky indentation. Make sure all your indents are the same! (ex: lines 27, 32, 99, 116 are more indented than others)

elladurham commented 9 years ago

Regarding vowels, I prefer spelling out the entire word. It's not like it's going to add tons of time to loading and hamper performance. However, I do understand that some people prefer to abbreviate or remove vowels. As long as what you are doing is consistent and you are at least following hyphens-between-words-all-lowercase then you're alright.