More modernization - Githubissues

CouscousPHP / Couscous

Couscous is good.

https://couscous.io

Other

841 stars 104 forks source link

More modernization #260

Closed alanpoulain closed 3 years ago

alanpoulain commented 4 years ago

Little fixes in the source code (mainly from PHP Inspections)
Use latest PHPUnit
Declare strict typehint in test files
Add typehint in test files
Replace the PHPUnit's deprecated methods

@Baptouuuu :slightly_smiling_face:

alanpoulain commented 4 years ago

I've added some comments, the PR changes a lot of things in a single commit, so it's really hard to review and be confident

Oh sorry for that. I thought it was OK since it's mainly typehint in test files (and the tests are green). If you really prefer I can try to separate it in different commits (src files, typehint for test files, replacement of deprecated methods). Please tell me if you need this.

alanpoulain commented 3 years ago

Do you want me to revamp this PR? Maybe by doing small PRs instead?

mnapoli commented 3 years ago

Do you want me to revamp this PR? Maybe by doing small PRs instead?

Hi, yes 😅 I'm sorry, reviewing PRs takes a lot of time across all the repositories, and this one is huge and not top priority so I have a lot of trouble saving time for this.

Let's move forward and close this one, I don't think I'll be able to merge it. If you still want to, smaller (targeted) PRs would work better I think.

Thanks for your efforts and patience!