Rescue from Load Errors

Coveralls-Community / coveralls-ruby

Coveralls for Ruby

MIT License

5 stars 2 forks source link

Rescue from Load Errors #27

Closed tagliala closed 5 years ago

tagliala commented 5 years ago

Commit 1c349b2 changed LoadError to StandardError to fix some RuboCop offences.

As per Ruby docs, LoadError is not a subclass of StandardError but it is a subclass of ScriptError.

When we try to require files inside Coveralls, we are going to rescue From LoadError as well as StandardError.

Ref:

https://ruby-doc.org/core-2.6.3/Exception.html

coveralls commented 5 years ago

Coverage increased (+0.2%) to 91.512% when pulling 11408a9b535a21a3589dfcf8ff633d271417f5a7 on rescue-from-load-errors into ac05b89a4577c8056365a0e73cd59e6393b72a67 on master.