Covid-Self-report-Tool / cov-self-report-frontend

Frontend repository for COVID-19 self-reporting tool in React
https://www.covidselfreport.org
MIT License
10 stars 1 forks source link

Jsamra/adding spinner to email sign up button #57

Closed ajsamra closed 4 years ago

ajsamra commented 4 years ago

Issues resolved by this pull request

Prerequisites

Review type

Type Required (Y/N) Instructions
Deployed Y/N Click link near Deployed to below.
Local Y/N Check out this branch, run its start cmd
GitHub Y/N Review diffs and likely Markdown

Issue-specific review items

Errors

Style changes

Code changes

Documenting scripting languages

Conventions

Best practices
ajsamra commented 4 years ago

@abettermap I don't believe there are any other instances where the user is waiting while firebase authenticates. Were you thinking of anything specific?

abettermap commented 4 years ago

Oh I meant just waiting for requests to complete in general, not just firebase (e.g. "forgot passwd"). If you think of any please add an issue!

ajsamra commented 4 years ago

oh! Yes! I'll look through the whole flow and see where we should add this feedback while something is loading.