Set up GitHub Actions for dev deploys - Githubissues

Covid-Self-report-Tool / cov-self-report-frontend

Frontend repository for COVID-19 self-reporting tool in React

https://www.covidselfreport.org

MIT License

10 stars 1 forks source link

Set up GitHub Actions for dev deploys #74

Closed abettermap closed 4 years ago

abettermap commented 4 years ago

Issues resolved by this pull request

Closes #69 (gave up on that)

Review type

Type	Required (Y/N)	Instructions
`Deployed`	Y	Click link near `Deployed to` below.
`Local`	N	Check out this branch, run its start cmd
`GitHub`	N	Review diffs and likely Markdown

Items to ignore

Not connected to master or prod stuff yet (that is all still wired up with Amplify)
No tests yet
"This branch has not been deployed" PR comment (think it's something to do with GH pages)
PR comments with old/incorrect deploy URLs. Only the most recent one matters.

Issue-specific review items

The deploy URL in the comments below is:
- [x] ...obvious and easy to find.
- [x] ...functional.
[x] The issue/s in this request have been resolved.
[x] The stuff in the new files in .github/workflows/ makes sense-ish. It's the meat of this PR so give it a skim at least.
[x] The links that have been changed (see diffs) within the app work correctly. They were converted from absolute to relative because, up until now, every instance of the app (local, review, and prod) had a top-level URL, whereas these new review/deploy/staging URLs are much more nested.

General, standard review items

Errors

[x] Front-end: no DevTools console errors occur in the built code (PR review URL) in the step/s required to test the PR.

github-actions[bot] commented 4 years ago

Review link: https://covid-self-report-tool.github.io/cov-self-report-frontend/review/74-merge. Check Contexts and expression syntax for available variables.

github-actions[bot] commented 4 years ago

Review link: https://covid-self-report-tool.github.io/cov-self-report-frontend/review/74-merge. Check Contexts and expression syntax for available variables.

github-actions[bot] commented 4 years ago

Review link:

https://covid-self-report-tool.github.io/cov-self-report-frontend/review/74-merge

github-actions[bot] commented 4 years ago

🔗🔗 Review link 🔗🔗

This is the deployment URL for the reviewer: https://covid-self-report-tool.github.io/cov-self-report-frontend/review/jason-gh-actions-init

github-actions[bot] commented 4 years ago

🔗🔗 Review link 🔗🔗

This is the deployment URL for the reviewer: https://covid-self-report-tool.github.io/cov-self-report-frontend/review/jason-gh-actions-init

abettermap commented 4 years ago

@ajsamra if you end up merging this after reviewing, make sure you squash:

...instead of the usual. Reason being, many of my commits are just for testing since I had to push in order to see if the Actions worked. They don't add a ton of value and I'd rather not pollute the history with them. Normally I would just rebase them locally into something cleaner, but there were a lot of unknowns and new concepts in this branch so I just went with it.

Thanks and let me know if you have any questions!