search

CovingtonResearchGroup / champ

Model for bedrock channel evolution including self-adjusting cross-sectional shape.
0 stars 0 forks source link

multi-erosion timesteps potentially problematic #17

Open speleophysics opened 4 years ago

speleophysics commented 4 years ago

Timesteps with multiple airflow conditions (temps) were creating flattened XC shapes (ceiling) during phreatic flow conditions with large erosional rates. This was resulting from change in position of the ceiling without recalculation of flow (causing ceiling to not get eroded). I have fixed this by adding flow calculations in for each temperature sub-step. However, there may be a more efficient way to refactor this such that flow is only calculated once and all erosion is applied at the end of the timestep.

speleophysics commented 4 years ago

Here is the commit where I fixed the bug by adding extra flow calcs. e829d793794f98ee247720bfb8bda56a6e2e332f