Cowboy-coder / bundle-up

An asset manager for nodejs
MIT License
56 stars 22 forks source link

Add minfiication of javascript #3

Closed Cowboy-coder closed 12 years ago

Cowboy-coder commented 12 years ago

using UglifyJS https://github.com/mishoo/UglifyJS.

Make it together with minfiication of css configurable.

Should minification be default?

panosru commented 12 years ago

on the pull request I just send I just used your already existed method minify and added the support but I believe it shouldn't be by default, as I saw your code is well abstracted so bundle.coffee there where you call the minify method you could hook a statement where you would check if the minification should be processed or not

Cowboy-coder commented 12 years ago

Yeah, I think I agree with you that minification shouldn't be default.