search

Cox-Automotive / terraform-provider-alks

Terraform Provider for ALKS
MIT License
37 stars 23 forks source link

Sanitizing Documentation #173

Closed jared-bloomer closed 2 years ago

jared-bloomer commented 2 years ago

Description

Sanitizing Documentation to remove references to Cox Auto resources

Rally # (issue / story / spike) N/A

Type of change

Please remove options that are not relevant.

How has this been tested?

Steps:

N/A

Checklist / To Do:

Merge PR

americk0 commented 2 years ago

I don't mind approving this but just be aware that by no means is the ALKS URL a sensitive or even private piece of information. I second Tommy on updating the help link to point to cloud railway though

Edit: On second thought, having this URL included in the documentation saves our team time and improves usability, while hiding it provides marginal security at best. I still don't have a problem with changing the tags since that doesn't hurt usability but I want to hold off on the URL change unless I'm overruled by leadership

americk0 commented 2 years ago

This PR has been stale for a little while and we've decided not to accept this change for the reasons above. I do really appreciate the suggestion though so please feel free to submit PRs for any other issues you find. These changes may not have been accepted but it has sparked important conversations in our team