Cox-Automotive / terraform-provider-alks

Terraform Provider for ALKS
MIT License
37 stars 23 forks source link

incorrect test for max_session_duration_in_seconds? #174

Open matthewchao opened 2 years ago

matthewchao commented 2 years ago

In https://github.com/Cox-Automotive/terraform-provider-alks/blob/98820043caf4accc941b3daebe7333bc58b8a548/resource_alks_iamrole_test.go#L651-L658

the variable name indicates that perhaps no max_session_duration_in_seconds should be provided. I think the test at https://github.com/Cox-Automotive/terraform-provider-alks/blob/98820043caf4accc941b3daebe7333bc58b8a548/resource_alks_iamrole_test.go#L327-L328 was supposed to check for a default value, but as written, the test is no different from the one at https://github.com/Cox-Automotive/terraform-provider-alks/blob/98820043caf4accc941b3daebe7333bc58b8a548/resource_alks_iamrole_test.go#L46-L47