search

Cox-Automotive / terraform-provider-alks

Terraform Provider for ALKS
MIT License
37 stars 23 forks source link

Defect duplicate tags #196

Closed LumaC0 closed 12 months ago

LumaC0 commented 1 year ago

Change Log Items

Description

Adds a ResolveDuplicates function to check for tags from terraform's configuration along with tags retrieved directly from AWS. Most of the code was taken from this PR: https://github.com/hashicorp/terraform-provider-aws/pull/30793, removing interceptor code not relevant to the ALKS provider

Acceptance Tests Results

➜ make testacc TESTARGS="-run TestAccAlksIamRole"                                 

TF_ACC=1 go test -timeout 1200s -v . -run TestAccAlksIamRole
=== RUN   TestAccAlksIamRole_Basic
--- PASS: TestAccAlksIamRole_Basic (45.98s)
=== RUN   TestAccAlksIamRole_Tags
--- PASS: TestAccAlksIamRole_Tags (43.11s)
=== RUN   TestAccAlksIamRole_DefaultTags_TrustPolicy
--- PASS: TestAccAlksIamRole_DefaultTags_TrustPolicy (47.72s)
=== RUN   TestAccAlksIamRole_DefaultTags_TrustPolicyUpdate
--- PASS: TestAccAlksIamRole_DefaultTags_TrustPolicyUpdate (46.29s)
=== RUN   TestAccAlksIamRole_DefaultTags_RoleType
--- PASS: TestAccAlksIamRole_DefaultTags_RoleType (43.01s)
=== RUN   TestAccAlksIamRole_DefaultTagsEmpty
--- PASS: TestAccAlksIamRole_DefaultTagsEmpty (35.28s)
=== RUN   TestAccAlksIamRole_DefaultTagSameAsResourceTag
--- PASS: TestAccAlksIamRole_DefaultTagSameAsResourceTag (43.47s)
=== RUN   TestAccAlksIamRole_IgnoreTagsEmpty
--- PASS: TestAccAlksIamRole_IgnoreTagsEmpty (43.41s)
=== RUN   TestAccAlksIamRole_IgnoreTags
--- PASS: TestAccAlksIamRole_IgnoreTags (35.24s)
=== RUN   TestAccAlksIamRole_NoMaxDuration
--- PASS: TestAccAlksIamRole_NoMaxDuration (44.34s)
PASS
ok      github.com/Cox-Automotive/terraform-provider-alks       427.845s

Rally: DE379216: ALKS Terraform provider defect