coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 61
- 51 of 75 (68.0%) changed or added relevant lines in 17 files are covered.
- 16 unchanged lines in 9 files lost coverage.
- Overall coverage decreased (-0.6%) to 70.594%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| waimak-azure-table/src/main/scala/waimak/azure/table/SparkAzureTable.scala | 0 | 1 | 0.0% | ||
| waimak-core/src/main/scala/com/coxautodata/waimak/dataflow/InterceptorAction.scala | 1 | 2 | 50.0% | ||
| waimak-rdbm-export/src/main/scala/com/coxautodata/waimak/rdbm/export/MSSQLExportActions.scala | 0 | 1 | 0.0% | ||
| waimak-core/src/main/scala/com/coxautodata/waimak/dataflow/SimpleDataFlow.scala | 2 | 4 | 50.0% | ||
| waimak-core/src/main/scala/com/coxautodata/waimak/dataflow/DataFlowEntities.scala | 17 | 20 | 85.0% | ||
| waimak-core/src/main/scala/com/coxautodata/waimak/dataflow/spark/SimpleSparkDataFlow.scala | 0 | 5 | 0.0% | ||
| waimak-core/src/main/scala/com/coxautodata/waimak/dataflow/spark/SparkActions.scala | 6 | 17 | 35.29% | ||
| <!-- | Total: | 51 | 75 | 68.0% | --> |
| Totals | |
|---|---|
| Change from base Build 50: | -0.6% |
| Covered Lines: | 725 |
| Relevant Lines: | 1027 |
Description
When writing Spark data flows, we are currently restricted to having
Dataset[_]as the type for action inputs and outputs. In some scenarios we wish to output other types of information such as counters, but the type restriction is preventing us from doing this.This change allows
Anyvalues in the flow, removing the type parameterTfromDataFlowcompletely.This does not affect the high-level API, but it will affect any custom actions.
Type of change
How Has This Been Tested?
Changes to the tests were necessary to account for dropping the type parameter from
DataFlowbut otherwise they remained the same, and unit and integration tests are passing.